linux-kernel - Re: [PATCH v3 0/2] kbuild: Fix corner caches with .cache.mk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 09:37:27 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Mathieu Malaterre <malat@...ian.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Yang Shi <yang.s@...baba-inc.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Matthias Kaehlcke <mka@...omium.org>,
        Cao jin <caoj.fnst@...fujitsu.com>,
        Arnd Bergmann <arnd@...db.de>,
        Mark Charlebois <charlebm@...il.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Ingo Molnar <mingo@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v3 0/2] kbuild: Fix corner caches with .cache.mk

Hi,

On Tue, Mar 13, 2018 at 12:49 AM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> Hi Douglas,
>
>
> 2018-03-13 15:11 GMT+09:00 Douglas Anderson <dianders@...omium.org>:
>> This two-patches fixes two corner cases with .cache.mk that have been
>> reported.  Neither problem was catastrophic, but certainly several
>> people ran into the problem solved by the first patch (can't build
>> after gcc upgrade) and wasted time debugging, so it's really a good
>> idea to fix.
>>
>> Sorry for the big delay between v2 and v3.  I never quite caught up
>> with email after the holidays, but hopefully better late than never...
>
>
> If v3 had been sent in time for v4.15
> I would have immediately queued it up.

Sigh.  My apologies again for sitting on this for so long.  :(


> But, the situation has changed.
>
> The direction of the development is
> to move the compiler flags evaluation to the Kconfig phase,
> and remove the Kbuild cache.
>
>
> If you are interested in the background,
> here are some of resources:
>
> Linus' comment that finally moved this work forward:
> https://lkml.org/lkml/2018/2/7/527
>
> Tons of discussion about the initial version:
> https://patchwork.kernel.org/patch/10207385/
>
> The core patch in the latest version:
> https://patchwork.kernel.org/patch/10225355/
>
>
> And, I am removing the Kbuild cache entirely:
> https://patchwork.kernel.org/patch/10225437/

Oh, that's great!


> I do not know how to handle your patches
> since I am removing the addressed code for 4.17-rc1,
> which is comming in a month or so.
>
> If this is a fatal problem, we can queue it up
> only for 4.16, but I do not hear problem reports these days...

Just drop them.  Ingo hated patch 2/2, and (like you) I haven't heard
any complaints about the problems described by patch 1/2 in the last
few months.  I got back to this because I told myself I would try to
re-focus on upstream stuff while I was at ELC, not because I suddenly
got another stream of complaints.  ;)


Anyway, glad to here you've come up with a better solution for the
future and we can get rid of the cache.  Thank you for all your hard
work!


-Doug