linux-kernel - Re: [alsa-devel] [PATCH v4 15/24] ASoC: qdsp6: q6core: Add q6core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 13:55:40 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rohit Kumar <rohitkr@...eaurora.org>, andy.gross@...aro.org,
        broonie@...nel.org, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, robh+dt@...nel.org
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        bgoswami@...eaurora.org, rohkumar@....qualcomm.com,
        gregkh@...uxfoundation.org, plai@...eaurora.org,
        lgirdwood@...il.com, tiwai@...e.com, david.brown@...aro.org,
        linux-arm-kernel@...ts.infradead.org, spatakok@....qualcomm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH v4 15/24] ASoC: qdsp6: q6core: Add q6core
 driver

Thanks Rohit for review comments,

On 13/03/18 11:46, Rohit Kumar wrote:
> 
> 
> On 3/10/2018 7:54 AM, srinivas.kandagatla@...aro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> [..]
>> +static int q6core_get_svc_versions(struct q6core *core)
>> +{
>> +    struct apr_device *adev = core->adev;
>> +    struct apr_hdr hdr = {0};
>> +    int rc;
>> +
>> +    core->get_version_supported = true;
> 
> core->get_version_supported should be set to true only after we get 
> proper response from adsp in callback(). In case,we get wrong response 
> from adsp, memory for g_core->svc_version
>   will not get allocated and there will be NULL pointer dereference in  
> q6core_get_svc_api_info() in below statement

I totally agree with you , this line seems to be a leftover from 
previous patches, It should be removed.

thanks,
srini
> +    } else if (g_core->get_version_supported) {
> +        for (i = 0; i < g_core->svc_version->num_services; i++) {
> 
> 
>> +    hdr.hdr_field = APR_HDR_FIELD(APR_MSG_TYPE_SEQ_CMD,
>> +                      APR_HDR_LEN(APR_HDR_SIZE), APR_PKT_VER);
>> +    hdr.pkt_size = APR_HDR_SIZE;
>> +    hdr.opcode = AVCS_GET_VERSIONS;
>> +
>> +    rc = apr_send_pkt(adev, &hdr);
>> +    if (rc < 0)
>> +        return rc;
>> +