lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Mar 2018 22:17:58 -0700 From: Josh Elsasser <jelsasser@...neta.com> To: Cong Wang <xiyou.wangcong@...il.com> Cc: David Miller <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Eric Dumazet <edumazet@...gle.com>, Sasha Levin <alexander.levin@...izon.com>, Willem de Bruijn <willemb@...gle.com>, Alexander Potapenko <glider@...gle.com>, Michal Kubeček <mkubecek@...e.cz>, Linux Kernel Network Developers <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/1] net: check dev->reg_state before deref of napi netdev_ops On Mon, Mar 12, 2018 at 4:17 PM, Cong Wang <xiyou.wangcong@...il.com> wrote: > On Sun, Mar 11, 2018 at 12:22 PM, Josh Elsasser <jelsasser@...neta.com> wrote: >> init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads >> to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi >> wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. >> >> Avoid this by ensuring that napi->dev is not a dummy device before >> dereferencing napi dev's netdev_ops, preventing the following panic: > > Hmm, how about just checking ->netdev_ops? Checking reg_state looks > odd, although works. Fair point. I was trying to differentiate between an unexpected NULL pointer and a dummy netdev, but I guess it was clever at the expense of readability. I'll push up a v2 that just does the obvious.
Powered by blists - more mailing lists