linux-kernel - Re: [alsa-devel] [PATCH][next] ASoC: samsung: remove redundant pointer cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Mar 2018 01:45:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     kbuild-all@...org, Krzysztof Kozlowski <krzk@...nel.org>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH][next] ASoC: samsung: remove redundant
 pointer cpu_dai

Hi Colin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[cannot apply to next-20180314]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Colin-King/ASoC-samsung-remove-redundant-pointer-cpu_dai/20180314-232924
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   sound/soc/samsung/snow.c: In function 'snow_late_probe':
>> sound/soc/samsung/snow.c:52:31: error: 'cpu_dai' undeclared (first use in this function); did you mean 'cpu_data'?
     ret = snd_soc_dai_set_sysclk(cpu_dai, SAMSUNG_I2S_RCLKSRC_0,
                                  ^~~~~~~
                                  cpu_data
   sound/soc/samsung/snow.c:52:31: note: each undeclared identifier is reported only once for each function it appears in

vim +52 sound/soc/samsung/snow.c

31c26a6a Tushar Behera 2014-04-28  35  
31c26a6a Tushar Behera 2014-04-28  36  static int snow_late_probe(struct snd_soc_card *card)
31c26a6a Tushar Behera 2014-04-28  37  {
5015920a Mengdong Lin  2015-11-18  38  	struct snd_soc_pcm_runtime *rtd;
5015920a Mengdong Lin  2015-11-18  39  	struct snd_soc_dai *codec_dai;
31c26a6a Tushar Behera 2014-04-28  40  	int ret;
31c26a6a Tushar Behera 2014-04-28  41  
5015920a Mengdong Lin  2015-11-18  42  	rtd = snd_soc_get_pcm_runtime(card, card->dai_link[0].name);
5015920a Mengdong Lin  2015-11-18  43  	codec_dai = rtd->codec_dai;
5015920a Mengdong Lin  2015-11-18  44  
31c26a6a Tushar Behera 2014-04-28  45  	/* Set the MCLK rate for the codec */
31c26a6a Tushar Behera 2014-04-28  46  	ret = snd_soc_dai_set_sysclk(codec_dai, 0,
31c26a6a Tushar Behera 2014-04-28  47  					FIN_PLL_RATE, SND_SOC_CLOCK_IN);
31c26a6a Tushar Behera 2014-04-28  48  	if (ret < 0)
31c26a6a Tushar Behera 2014-04-28  49  		return ret;
31c26a6a Tushar Behera 2014-04-28  50  
31c26a6a Tushar Behera 2014-04-28  51  	/* Select I2S Bus clock to set RCLK and BCLK */
31c26a6a Tushar Behera 2014-04-28 @52  	ret = snd_soc_dai_set_sysclk(cpu_dai, SAMSUNG_I2S_RCLKSRC_0,
31c26a6a Tushar Behera 2014-04-28  53  					0, SND_SOC_CLOCK_IN);
31c26a6a Tushar Behera 2014-04-28  54  	if (ret < 0)
31c26a6a Tushar Behera 2014-04-28  55  		return ret;
31c26a6a Tushar Behera 2014-04-28  56  
31c26a6a Tushar Behera 2014-04-28  57  	return 0;
31c26a6a Tushar Behera 2014-04-28  58  }
31c26a6a Tushar Behera 2014-04-28  59  

:::::: The code at line 52 was first introduced by commit
:::::: 31c26a6a842d541ca475a482112dda5993df2374 ASoC: samsung: Add sound card driver for Snow board

:::::: TO: Tushar Behera <tushar.behera@...aro.org>
:::::: CC: Mark Brown <broonie@...aro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48060 bytes)