linux-kernel - Re: [PATCH v2 1/6] phy: rockchip-typec: fall back to working in host-mode if extcon is missing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Mar 2018 11:29:59 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Heiko Stübner <heiko@...ech.de>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>
CC:     <groeck@...omium.org>, <gwendal@...omium.org>,
        <kernel@...labora.com>, <vicencb@...il.com>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/6] phy: rockchip-typec: fall back to working in
 host-mode if extcon is missing.



On Wednesday 14 March 2018 01:44 PM, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Donnerstag, 1. März 2018, 16:25:10 CET schrieb Enric Balletbo i Serra:
>> Right now the rockchip type-c phy does fail probing when no extcon is
>> detected. Some boards get the cable-state via the extcon interface and
>> have this supported, other boards seem to use the fusb302 chip or
>> another but the driver currently does not seem to utilize the extcon
>> interface to report the cable-state. And, other, just connect the type-c
>> to a standard USB-A port so use no controller at all. A missing extcon
>> shouldn't fail to probe, instead, should just fall back to working in
>> host-mode if it cannot get the extcon.
>>
>> Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port
>> support for rk3399") Reported-by: Vicente Bergas <vicencb@...il.com>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> 
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> 
> I did revert the original commit mentioned in the fixes tag for 4.16-rc
> but it would nevertheless be really cool if these 2 patches (code + binding)
> could make it into your tree for 4.17 :-)
> 
> And ideally also with the other 5 patches from Enric starting at
> 	[PATCH v3 1/6] phy: rockchip-typec: deprecate some DT properties for various register fields.
> 
> from 2018-02-16.

merged now, thanks!

-Kishon