lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Mar 2018 20:50:58 -0400 From: Sinan Kaya <okaya@...eaurora.org> To: Alexander Duyck <alexander.duyck@...il.com> Cc: Netdev <netdev@...r.kernel.org>, Timur Tabi <timur@...eaurora.org>, sulrich@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan <intel-wired-lan@...ts.osuosl.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs On 3/15/2018 8:25 PM, Alexander Duyck wrote: > On Thu, Mar 15, 2018 at 4:30 PM, Sinan Kaya <okaya@...eaurora.org> wrote: >> On 3/14/2018 9:41 PM, Alexander Duyck wrote: >>>> } >>>> >>> So you missed the writel in e1000_xmit_frame. You should probably get >>> that one too while you are doing these updates. The wmb() is in >>> e1000_tx_queue(). >>> >> >> I brought wmb() outside along with the next descriptor assignment to be >> similar to the rest of the other code. >> >> if wmb() and writel() are not visible in the same function, let's not touch >> the code. > > Maybe for e1000 we should just skip the driver entirely. Odds are you > aren't going to have any e1000 parts running on ARM anyway since most > of them are legacy PCI or PCI-X parts that were made over 10 years > ago. Most of your efforts would probably be best spent on igb, igbvf, > ixgbe, ixgbevf, i40e, i40evf, and fm10k. > Sure. I'll drop it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists