lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Mar 2018 18:56:27 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Marcus Folkesson <marcus.folkesson@...il.com>, Wim Van Sebroeck <wim@...ana.be>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Carlo Caione <carlo@...one.org>, Kevin Hilman <khilman@...libre.com>, Matthias Brugger <matthias.bgg@...il.com>, Barry Song <baohua@...nel.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, Linus Walleij <linus.walleij@...aro.org>, Vladimir Zapolskiy <vz@...ia.com>, Sylvain Lemieux <slemieux.tyco@...il.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni <alexandre.belloni@...e-electrons.com> Cc: linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH v3 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree On 03/16/2018 06:37 AM, Marcus Folkesson wrote: > Hi, > > Am I supposed to do something more to make this patchset picked up? > Did you check linux-next ? Guenter > Thanks, > Marcus Folkesson > > On Sun, Feb 11, 2018 at 09:08:41PM +0100, Marcus Folkesson wrote: >> watchdog_init_timeout() will allways pick timeout_param since it >> defaults to a valid timeout. >> >> Following best practice described in >> Documentation/watchdog/watchdog-kernel-api.txt to make use of >> the parameter logic. >> >> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com> >> --- >> >> Notes: >> v3: >> - Use wdd->timeout instead of wdt_timeout when print out >> timout in probe function. >> >> drivers/watchdog/sama5d4_wdt.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c >> index 0ae947c3d7bc..255169916dbb 100644 >> --- a/drivers/watchdog/sama5d4_wdt.c >> +++ b/drivers/watchdog/sama5d4_wdt.c >> @@ -33,7 +33,7 @@ struct sama5d4_wdt { >> unsigned long last_ping; >> }; >> >> -static int wdt_timeout = WDT_DEFAULT_TIMEOUT; >> +static int wdt_timeout; >> static bool nowayout = WATCHDOG_NOWAYOUT; >> >> module_param(wdt_timeout, int, 0); >> @@ -212,7 +212,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) >> return -ENOMEM; >> >> wdd = &wdt->wdd; >> - wdd->timeout = wdt_timeout; >> + wdd->timeout = WDT_DEFAULT_TIMEOUT; >> wdd->info = &sama5d4_wdt_info; >> wdd->ops = &sama5d4_wdt_ops; >> wdd->min_timeout = MIN_WDT_TIMEOUT; >> @@ -273,7 +273,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, wdt); >> >> dev_info(&pdev->dev, "initialized (timeout = %d sec, nowayout = %d)\n", >> - wdt_timeout, nowayout); >> + wdd->timeout, nowayout); >> >> return 0; >> } >> -- >> 2.15.1 >>
Powered by blists - more mailing lists