lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Mar 2018 20:08:11 -0700 From: John Hubbard <jhubbard@...dia.com> To: <jglisse@...hat.com>, <linux-mm@...ck.org> CC: Andrew Morton <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>, Evgeny Baskakov <ebaskakov@...dia.com>, Ralph Campbell <rcampbell@...dia.com>, Mark Hairgrove <mhairgrove@...dia.com> Subject: Re: [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters On 03/16/2018 12:14 PM, jglisse@...hat.com wrote: > From: Jérôme Glisse <jglisse@...hat.com> > Hi Jerome, I failed to find any problems in this patch, so: Reviewed-by: John Hubbard <jhubbard@...dia.com> There are a couple of documentation recommended typo fixes listed below, which are very minor but as long as I'm here I'll point them out. > Both hmm_vma_fault() and hmm_vma_get_pfns() were taking a hmm_range > struct as parameter and were initializing that struct with others of > their parameters. Have caller of those function do this as they are > likely to already do and only pass this struct to both function this > shorten function signature and make it easiers in the future to add easier > new parameters by simply adding them to the structure. > > Signed-off-by: Jérôme Glisse <jglisse@...hat.com> > Cc: Evgeny Baskakov <ebaskakov@...dia.com> > Cc: Ralph Campbell <rcampbell@...dia.com> > Cc: Mark Hairgrove <mhairgrove@...dia.com> > Cc: John Hubbard <jhubbard@...dia.com> > --- > include/linux/hmm.h | 18 ++++--------- > mm/hmm.c | 78 +++++++++++++++++++---------------------------------- > 2 files changed, 33 insertions(+), 63 deletions(-) <snip> > > > diff --git a/mm/hmm.c b/mm/hmm.c > index 64d9e7dae712..49f0f6b337ed 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -490,11 +490,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > > /* > * hmm_vma_get_pfns() - snapshot CPU page table for a range of virtual addresses > - * @vma: virtual memory area containing the virtual address range > - * @range: used to track snapshot validity > - * @start: range virtual start address (inclusive) > - * @end: range virtual end address (exclusive) > - * @entries: array of hmm_pfn_t: provided by the caller, filled in by function > + * @range: range being snapshoted and all needed informations Let's just say this: * @range: range being snapshotted <snip> > @@ -628,11 +617,7 @@ EXPORT_SYMBOL(hmm_vma_range_done); > > /* > * hmm_vma_fault() - try to fault some address in a virtual address range > - * @vma: virtual memory area containing the virtual address range > - * @range: use to track pfns array content validity > - * @start: fault range virtual start address (inclusive) > - * @end: fault range virtual end address (exclusive) > - * @pfns: array of hmm_pfn_t, only entry with fault flag set will be faulted > + * @range: range being faulted and all needed informations Similarly here, let's just write it like this: * @range: range being faulted thanks, -- John Hubbard NVIDIA
Powered by blists - more mailing lists