lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Mar 2018 09:58:28 +0530 From: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> To: Oleg Nesterov <oleg@...hat.com> Cc: mhiramat@...nel.org, peterz@...radead.org, srikar@...ux.vnet.ibm.com, acme@...nel.org, ananth@...ux.vnet.ibm.com, akpm@...ux-foundation.org, alexander.shishkin@...ux.intel.com, alexis.berlemont@...il.com, corbet@....net, dan.j.williams@...el.com, gregkh@...uxfoundation.org, huawei.libin@...wei.com, hughd@...gle.com, jack@...e.cz, jglisse@...hat.com, jolsa@...hat.com, kan.liang@...el.com, kirill.shutemov@...ux.intel.com, kjlx@...pleofstupid.com, kstewart@...uxfoundation.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhocko@...e.com, milian.wolff@...b.com, mingo@...hat.com, namhyung@...nel.org, naveen.n.rao@...ux.vnet.ibm.com, pc@...ibm.com, pombredanne@...b.com, rostedt@...dmis.org, tglx@...utronix.de, tmricht@...ux.vnet.ibm.com, willy@...radead.org, yao.jin@...ux.intel.com, fengguang.wu@...el.com, Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> Subject: Re: [PATCH 5/8] trace_uprobe: Support SDT markers having reference count (semaphore) Hi Oleg, On 03/14/2018 10:29 PM, Oleg Nesterov wrote: > On 03/13, Ravi Bangoria wrote: >> +static bool sdt_valid_vma(struct trace_uprobe *tu, struct vm_area_struct *vma) >> +{ >> + unsigned long vaddr = vma_offset_to_vaddr(vma, tu->ref_ctr_offset); >> + >> + return tu->ref_ctr_offset && >> + vma->vm_file && >> + file_inode(vma->vm_file) == tu->inode && >> + vma->vm_flags & VM_WRITE && >> + vma->vm_start <= vaddr && >> + vma->vm_end > vaddr; >> +} > Perhaps in this case a simple > > ref_ctr_offset < vma->vm_end - vma->vm_start > > check without vma_offset_to_vaddr() makes more sense, but I won't insist. > I still don't get this. This seems a comparison between file offset and size of the vma. Shouldn't we need to consider pg_off here? Thanks, Ravi
Powered by blists - more mailing lists