linux-kernel - Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Mar 2018 11:30:06 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Pavel Machek <pavel@....cz>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

Hi,

On Fri, Mar 23, 2018 at 11:09:30AM +0100, Pavel Machek wrote:
> Hi!
> 
> > > # CONFIG_SND_OMAP_SOC_RX51 is not set
> > > # CONFIG_SND_OMAP_SOC_N9 is not set
> > > CONFIG_SND_OMAP_SOC_OMAP_TWL4030=y
> > > CONFIG_SND_OMAP_SOC_OMAP_ABE_TWL6040=y
> > 
> > That's not needed (but does not hurt). The Droid 4
> > has no TWL companion chip and uses CPCAP instead.
> 
> Aha, thanks. I was doing wild experiments to get something that
> boots... I turned them off.
> 
> > > Any ideas?
> > 
> > You probably did not enable the soundcard driver, that binds against
> > "audio-graph-card" compatible and connects the codec driver with the
> > SoC driver: CONFIG_SND_AUDIO_GRAPH_CARD
> 
> Ok, that certainly changed things; I am now getting this:
> 
> Mar 23 08:39:17 devuan kernel: [   11.633605] asoc-audio-graph-card soundcard: GPIO lookup for
>  consumer pa
> Mar 23 08:39:17 devuan kernel: [   11.644958] asoc-audio-graph-card soundcard: using device tr
> ee for GPIO lookup
> Mar 23 08:39:17 devuan kernel: [   11.656677] of_get_named_gpiod_flags: can't parse 'pa-gpios'
>  property of node '/soundcard[0]'
> Mar 23 08:39:17 devuan kernel: [   11.669738] of_get_named_gpiod_flags: can't parse 'pa-gpio' 
> property of node '/soundcard[0]'
> Mar 23 08:39:17 devuan kernel: [   11.682617] asoc-audio-graph-card soundcard: using lookup ta
> bles for GPIO lookup
> Mar 23 08:39:17 devuan kernel: [   11.694427] asoc-audio-graph-card soundcard: lookup for GPIO
>  pa failed

That's not an error, but just some debug messages. Consider
disabling CONFIG_DEBUG_GPIO to get rid of them.

> Indeed the dts does not seem to contain any gpios

It's optional and does not exist on Droid 4.

>         soundcard {
>                 compatible = "audio-graph-card";
>                 label = "Droid 4 Audio";
> 
>                 simple-graph-card,widgets =
>                         "Speaker", "Earpiece",
>                         "Speaker", "Loudspeaker",
> 	                "Headphone", "Headphone Jack",
> 	                "Microphone", "Internal Mic";
> 
>                 simple-graph-card,routing =
> 	                "Earpiece", "EP",
> 		        "Loudspeaker", "SPKR",
>                         "Headphone Jack", "HSL",
>                         "Headphone Jack", "HSR",
> 	                "MICR", "Internal Mic";
> 
>                 dais = <&mcbsp2_port>, <&mcbsp3_port>;
> 	};
> 
> Any more ideas? :-)

Make sure, that the device was not proped properly (cat
/proc/asound/cards) and post the real error? :)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)