linux-kernel - Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Mar 2018 15:09:47 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

Hi!

> That's not an error, but just some debug messages. Consider
> disabling CONFIG_DEBUG_GPIO to get rid of them.
> 
> > Indeed the dts does not seem to contain any gpios
> 
> It's optional and does not exist on Droid 4.
> 
> >         soundcard {
...
> > 	};
> > 
> > Any more ideas? :-)
> 
> Make sure, that the device was not proped properly (cat
> /proc/asound/cards) and post the real error? :)

Thanks, it is indeed a config problem. When I disabled "unrelated"
options, these got disabled, too:

They can be only selected, and there's nothing to select them in Droid
4 case.
								Pavel

diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index 2772414..7860b6e 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -4,13 +4,13 @@ config SND_OMAP_SOC
 	select SND_DMAENGINE_PCM
 
 config SND_OMAP_SOC_DMIC
-	tristate
+	tristate "dmic"
 
 config SND_OMAP_SOC_MCBSP
-	tristate
+	tristate "mcbsp"
 
 config SND_OMAP_SOC_MCPDM
-	tristate
+	tristate "mcpdm"
 
 config SND_OMAP_SOC_HDMI_AUDIO
 	tristate "HDMI audio support for OMAP4+ based SoCs"






-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)