linux-kernel - RE: [RFC PATCH net-next] tipc: tipc_disc_addr_trial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Mar 2018 12:57:25 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     kbuild test robot <fengguang.wu@...el.com>
CC:     "kbuild-all@...org" <kbuild-all@...org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ying Xue <ying.xue@...driver.com>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be
 static

Acked-by: Jon Maloy jon.maloy@...csson.com

Thanks, Fengguang

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of kbuild test robot
> Sent: Friday, March 23, 2018 15:48
> To: Jon Maloy <jon.maloy@...csson.com>
> Cc: kbuild-all@...org; netdev@...r.kernel.org; Ying Xue
> <ying.xue@...driver.com>; tipc-discussion@...ts.sourceforge.net; linux-
> kernel@...r.kernel.org
> Subject: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static
> 
> 
> Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash
> values")
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  discover.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/net/tipc/discover.c b/net/tipc/discover.c index e765573..9f666e0
> 100644
> --- a/net/tipc/discover.c
> +++ b/net/tipc/discover.c
> @@ -134,13 +134,13 @@ static void disc_dupl_alert(struct tipc_bearer *b,
> u32 node_addr,
> 
>  /* tipc_disc_addr_trial(): - handle an address uniqueness trial from peer
>   */
> -bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> -			      struct tipc_media_addr *maddr,
> -			      struct tipc_bearer *b,
> -			      u32 dst, u32 src,
> -			      u32 sugg_addr,
> -			      u8 *peer_id,
> -			      int mtyp)
> +static bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> +				     struct tipc_media_addr *maddr,
> +				     struct tipc_bearer *b,
> +				     u32 dst, u32 src,
> +				     u32 sugg_addr,
> +				     u8 *peer_id,
> +				     int mtyp)
>  {
>  	struct net *net = d->net;
>  	struct tipc_net *tn = tipc_net(net);