linux-kernel - [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 03:26:33 +0430
From:   Nasser Afshin <afshin.nasser@...il.com>
To:     mchehab@...nel.org
Cc:     p.zabel@...gutronix.de, sakari.ailus@...ux.intel.com,
        hans.verkuil@...co.com, bparrot@...com, garsilva@...eddedor.com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nasser Afshin <Afshin.Nasser@...il.com>
Subject: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down
resistor if it's been disabled. On hardware that does not have such
resistor, we should use the default output enable value.
This prevents the color burst lock instability problem.

Signed-off-by: Nasser Afshin <Afshin.Nasser@...il.com>
---
 drivers/media/i2c/tvp5150.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 2476d812f669..0e9713814816 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -328,7 +328,7 @@ static const struct i2c_reg_value tvp5150_init_default[] = {
 		TVP5150_OP_MODE_CTL,0x00
 	},
 	{ /* 0x03 */
-		TVP5150_MISC_CTL,0x01
+		TVP5150_MISC_CTL,0x21
 	},
 	{ /* 0x06 */
 		TVP5150_COLOR_KIL_THSH_CTL,0x10
@@ -1072,7 +1072,8 @@ static int tvp5150_s_stream(struct v4l2_subdev *sd, int enable)
 		 * Enable the YCbCr and clock outputs. In discrete sync mode
 		 * (non-BT.656) additionally enable the the sync outputs.
 		 */
-		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE;
+		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE |
+			TVP5150_MISC_CTL_INTREQ_OE;
 		if (decoder->mbus_type == V4L2_MBUS_PARALLEL)
 			val |= TVP5150_MISC_CTL_SYNC_OE;
 	}
-- 
2.15.0