linux-kernel - Re: [PATCH] genirq: Pass desc to __irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 17:35:29 +0200
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] genirq: Pass desc to __irq_free instead of irq number

Hello Thomas,

On Mon, Mar 26, 2018 at 11:43:27AM +0200, Thomas Gleixner wrote:
> On Mon, 26 Mar 2018, Uwe Kleine-König wrote:
> > 
> > On Mon, Mar 19, 2018 at 11:52:02AM +0100, Uwe Kleine-König wrote:
> > > Given that irq_to_desc() is a radix_tree_lookup and the reverse
> > > operation is only a pointer dereference and that all callers of
> > > __free_irq already have the desc, pass the desc instead of the irq
> > > number.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > ---
> > > Hello,
> > > 
> > > this is a micro optimisation I noticed while looking at the irq code.
> > 
> > This made it into next as 83ac4ca943affce56a2c408ddb2f5232f478fb11 and
> > ba63053f018721a0ad60b083e21a15e324a4a8c4. Is it right that it is there
> > twice?
> 
> No. It's only one instance.

$ git log --oneline linus/master..next/master --grep='genirq: Pass desc to __irq_free'
83ac4ca943af genirq: Pass desc to __irq_free instead of irq number
ba63053f0187 genirq: Pass desc to __irq_free instead of irq number

$ git show 83ac4ca943af ba63053f0187 | git patch-id
ee0091f074eb45677b190f29e30ab97adad449d9 83ac4ca943affce56a2c408ddb2f5232f478fb11
ee0091f074eb45677b190f29e30ab97adad449d9 ba63053f018721a0ad60b083e21a15e324a4a8c4

They both come into next by commit c5b27fb35b1a ("Merge remote-tracking branch
'tip/auto-latest'"):

$ git rev-parse c5b27fb35b1a^2^2~4
83ac4ca943affce56a2c408ddb2f5232f478fb11
$ git rev-parse c5b27fb35b1a^2~25^2
ba63053f018721a0ad60b083e21a15e324a4a8c4

You still claim there is only one instance, I assume that's because the branch
that is pulled into next (tip/auto-latest) is autogenerated and contains some
cruft?

> > And in the Author line the - in my name is missing. Would be great if
> > that could be fixed up.
> 
> Sorry, I'm surely not rebasing that branch just to add a missing dash.

:-| I wonder how this error happend. Is there a script to fix? If so I'd
like to take a look.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |