linux-kernel - RE: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Mar 2018 07:02:12 +0000
From:   Razvan Stefanescu <razvan.stefanescu@....com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     Allan Nielsen <Allan.Nielsen@...rosemi.com>,
        Po Liu <po.liu@....com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>
Subject: RE: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

Hello Alexandre,

> +
> +	register_netdevice_notifier(&ocelot_netdevice_nb);
> +
> +	dev_info(&pdev->dev, "Ocelot switch probed\n");
> +
> +	return 0;
> +
> +err_probe_ports:
> +	return err;
> +}
> +
> +static int mscc_ocelot_remove(struct platform_device *pdev)
> +{
> +	unregister_netevent_notifier(&ocelot_netdevice_nb);

This should be replaced with a call to unregister_netdevice_notifier(). And also makes
the inclusion of net/netevent.h not necessary.

Best regards,
Razvan