linux-kernel - Re: [PATCH] time: export nsec_to_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Apr 2018 15:55:50 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Zhang Rui <rui.zhang@...el.com>, Arnd Bergmann <arnd@...db.de>,
        John Stultz <john.stultz@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-kernel@...r.kernel.org, edubezval@...il.com
Subject: Re: [PATCH] time: export nsec_to_clock_t

On 29-03-18, 21:11, Thomas Gleixner wrote:
> On Thu, 29 Mar 2018, Zhang Rui wrote:
> > On 三, 2018-03-28 at 16:11 +0200, Arnd Bergmann wrote:
> > > nsec_to_clock_t was traditionally used only in the core kernel, now
> > > we
> > > have a sysfs file that needs it from a loadable module, causing a
> > > link-time error:
> > > 
> > > ERROR: "nsec_to_clock_t" [drivers/thermal/thermal_sys.ko] undefined!
> > > 
> > > This exports the function the same way that we do for related
> > > interfaces.
> > > 
> > > Fixes: 96cea33badc5 ("thermal: Add cooling device's statistics in
> > > sysfs")
> > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > 
> > Thanks for the fix.
> > can I take this patch through thermal tree?
> 
> Well, the question is what's the point of that?
> 
> Why does a new interface expose time in state in clock_t instead in normal
> time units, e.g. nsec/usec/msec ?

The initial patch was displaying the values in msec, but eduardo asked the units
to be consistent with how cpufreq shows it, i.e. clock_t.

https://lkml.kernel.org/r/20180112174606.GA11076@localhost.localdomain 

Anyway I will resend the patch and move back to msec. Thanks.

-- 
viresh