lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Apr 2018 04:43:35 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Quytelda Kahja <quytelda@...alin.org> Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org, linux-kernel@...r.kernel.org, wsa@...-dreams.de Subject: Re: [PATCH v2 71/75] staging: ks7010: Remove dummy address set. On Sat, Mar 31, 2018 at 11:46:40AM +0300, Dan Carpenter wrote: > On Fri, Mar 30, 2018 at 11:08:51PM -0700, Quytelda Kahja wrote: > > Setting a dummy address during the driver probe is not necessary. > > The dev_addr field is already zeroed out from alloc_etherdev(). > > > > Signed-off-by: Quytelda Kahja <quytelda@...alin.org> > > --- > > drivers/staging/ks7010/ks_wlan_net.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > > index 5c5569000fce..afbc472baa05 100644 > > --- a/drivers/staging/ks7010/ks_wlan_net.c > > +++ b/drivers/staging/ks7010/ks_wlan_net.c > > @@ -2852,9 +2852,6 @@ int ks_wlan_close(struct net_device *dev) > > /* Operational parameters that usually are not changed. */ > > /* Time in jiffies before concluding the transmitter is hung. */ > > #define TX_TIMEOUT (3 * HZ) > > -static const unsigned char dummy_addr[] = { > > - 0x00, 0x0b, 0xe3, 0x00, 0x00, 0x00 > > Of course, this isn't a zero address. Do we know why they chose this > particular address? I was expecting it to be zero from the patch > description. > > regards, > dan carpenter > Quytelda asked me about this patch privately. When I originally read the commit description, I basically saw that we're removing code because the dev_addr was already initialized to zero. But actaully it says that we're just removing nonsense code. So that's fine. regards, dan carpenter
Powered by blists - more mailing lists