linux-kernel - Re: [PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Apr 2018 09:50:53 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Suman Anna <s-anna@...com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Dave Gerlach <d-gerlach@...com>, Tero Kristo <t-kristo@...com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zumeng Chen <zumeng.chen@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error
 return value

On 02-04-18, 11:49, Suman Anna wrote:
> Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when
> failure") has fixed a memory leak in the failure path, however
> the patch returned a positive value on get_cpu_device() failure
> instead of the previous negative value. Fix this incorrect error
> return value properly.
> 
> Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")
> Cc: Zumeng Chen <zumeng.chen@...il.com>
> Cc: stable@...r.kernel.org

You also need to mention which version of the stable kernel this patch
should be applied to, like this:

Cc: 3.15+ <stable@...r.kernel.org> # v3.15+

Rafael would probably fix this while applying, so no need to resend
again for now.

> Signed-off-by: Suman Anna <s-anna@...com>
> ---
>  drivers/cpufreq/ti-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index a099b7bf74cd..46d1ab2dea87 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
>  	opp_data->cpu_dev = get_cpu_device(0);
>  	if (!opp_data->cpu_dev) {
>  		pr_err("%s: Failed to get device for CPU0\n", __func__);
> -		ret = ENODEV;
> +		ret = -ENODEV;
>  		goto free_opp_data;
>  	}

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh