linux-kernel - Re: [PATCH v4 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Apr 2018 05:04:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rui Miguel Silva <rui.silva@...aro.org>
Cc:     kbuild-all@...org, mchehab@...nel.org,
        sakari.ailus@...ux.intel.com, hverkuil@...all.nl,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ryan Harkin <ryan.harkin@...aro.org>,
        Rui Miguel Silva <rui.silva@...aro.org>
Subject: Re: [PATCH v4 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Rui,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.16]
[cannot apply to linuxtv-media/master next-20180403]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-Introduce-Omnivision-OV2680-driver/20180404-032903
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   drivers/media//i2c/ov2680.c: In function 'ov2680_set_fmt':
>> drivers/media//i2c/ov2680.c:692:9: error: implicit declaration of function 'v4l2_find_nearest_size'; did you mean 'v4l2_find_nearest_format'? [-Werror=implicit-function-declaration]
     mode = v4l2_find_nearest_size(ov2680_mode_data,
            ^~~~~~~~~~~~~~~~~~~~~~
            v4l2_find_nearest_format
>> drivers/media//i2c/ov2680.c:693:41: error: 'width' undeclared (first use in this function)
              ARRAY_SIZE(ov2680_mode_data), width,
                                            ^~~~~
   drivers/media//i2c/ov2680.c:693:41: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/media//i2c/ov2680.c:694:11: error: 'height' undeclared (first use in this function); did you mean 'hweight8'?
              height, fmt->width, fmt->height);
              ^~~~~~
              hweight8
   cc1: some warnings being treated as errors

vim +692 drivers/media//i2c/ov2680.c

   672	
   673	static int ov2680_set_fmt(struct v4l2_subdev *sd,
   674				  struct v4l2_subdev_pad_config *cfg,
   675				  struct v4l2_subdev_format *format)
   676	{
   677		struct ov2680_dev *sensor = to_ov2680_dev(sd);
   678		struct v4l2_mbus_framefmt *fmt = &format->format;
   679		const struct ov2680_mode_info *mode;
   680		int ret = 0;
   681	
   682		if (format->pad != 0)
   683			return -EINVAL;
   684	
   685		mutex_lock(&sensor->lock);
   686	
   687		if (sensor->is_streaming) {
   688			ret = -EBUSY;
   689			goto unlock;
   690		}
   691	
 > 692		mode = v4l2_find_nearest_size(ov2680_mode_data,
 > 693					      ARRAY_SIZE(ov2680_mode_data), width,
 > 694					      height, fmt->width, fmt->height);
   695		if (!mode) {
   696			ret = -EINVAL;
   697			goto unlock;
   698		}
   699	
   700		if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
   701			fmt = v4l2_subdev_get_try_format(sd, cfg, 0);
   702	
   703			*fmt = format->format;
   704			goto unlock;
   705		}
   706	
   707		fmt->width = mode->width;
   708		fmt->height = mode->height;
   709		fmt->code = sensor->fmt.code;
   710		fmt->colorspace = sensor->fmt.colorspace;
   711	
   712		sensor->current_mode = mode;
   713		sensor->fmt = format->format;
   714		sensor->mode_pending_changes = true;
   715	
   716	unlock:
   717		mutex_unlock(&sensor->lock);
   718	
   719		return ret;
   720	}
   721	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48060 bytes)