[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 4 Apr 2018 11:34:55 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Kees Cook <keescook@...omium.org>,
LKML <linux-kernel@...r.kernel.org>,
"Tobin C. Harding" <me@...in.cc>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
David Laight <David.Laight@...lab.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v2] tracing, printk: Force no hashing when trace_printk()
is used
On (04/03/18 18:03), Steven Rostedt wrote:
>
> > he'd want you to change all the trace_printk()s to %px with
> > justifications, though.
>
> What trace_printk()s do you want to change? They are throw away
> functions. trace_printk() is not something that stays in the kernel.
> It's added during debugging and then removed before submitting what you
> are working on upstream.
Seems that your patch also can fix up bpf_trace_printk() - it doesn't
even support %px, only hashed %p, which it passes to __trace_printk().
-ss
Powered by blists - more mailing lists