>From 121724c8bb9d5c07ee12718520f6f99b0da0a275 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Mon, 9 Apr 2018 16:17:44 +0200 Subject: [PATCH] reiserfs: Fix warning for non-existing journal devices When a journal device specified as part of mount options does not exist, reiserfs issues a warking like: reiserfs_warning(super, "journal_init_dev: Cannot open '%s': %i", jdev_name, result); Now this misses a parameter 'id' of reiserfs_warning() which comes second. As such, the format string is interpreted as an ID and jdev_name as a format string resulting in funny issues. Fix the problem by adding missing 'id' argument. Reported-by: Randy Dunlap Signed-off-by: Andrew Morton Acked-by: Jeff Mahoney Signed-off-by: Jan Kara --- fs/reiserfs/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 70057359fbaf..23148c3ed675 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c @@ -2643,7 +2643,7 @@ static int journal_init_dev(struct super_block *super, if (IS_ERR(journal->j_dev_bd)) { result = PTR_ERR(journal->j_dev_bd); journal->j_dev_bd = NULL; - reiserfs_warning(super, + reiserfs_warning(super, "sh-457", "journal_init_dev: Cannot open '%s': %i", jdev_name, result); return result; -- 2.13.6