linux-kernel - Re: [PATCH] perf session: Fix undeclared 'oe'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Apr 2018 21:33:53 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Murilo Opsfelder Araujo <muriloo@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        He Kuang <hekuang@...wei.com>, Ingo Molnar <mingo@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Paul Mackerras <paulus@...ba.org>,
        Paul Turner <pjt@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Sasha Levin <alexander.levin@...rosoft.com>,
        Simon Que <sque@...omium.org>,
        Stephane Eranian <eranian@...gle.com>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH] perf session: Fix undeclared 'oe'

On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:
> Using linux-3.18.y branch, perf build fails with the following:
> 
>     $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
>     [...]
>     util/session.c: In function ‘__perf_session__process_pipe_events’:
>     util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
>       ordered_events__set_copy_on_queue(oe, true);
>                                         ^
>     util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in
> 
> This patch fixes it for linux-3.18.y branch.

Why is this failing now?  Has it always been broken?  Is there an
upstream patch that fixed this instead?

> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")

Was this just a bad backport?

thanks,

greg k-h