linux-kernel - RE: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Apr 2018 15:46:14 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Sridhar Pitchai <Sridhar.Pitchai@...rosoft.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
CC:     Dexuan Cui <decui@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Jake Oshins <jakeo@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI
 domain"



> -----Original Message-----
> From: Sridhar Pitchai
> Sent: Thursday, April 12, 2018 11:14 AM
> To: Bjorn Helgaas <helgaas@...nel.org>; Lorenzo Pieralisi
> <lorenzo.pieralisi@....com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>; Dexuan Cui
> <decui@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> Jake Oshins <jakeo@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>;
> Michael Kelley (EOSG) <Michael.H.Kelley@...rosoft.com>;
> devel@...uxdriverproject.org; linux-pci@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI
> domain"
> 
>     >> I am still not happy with this patch.
>     >>
>     >> -  You do not explain at all the dependency on commit 0c195567a8f6 and
>     >>    you should because that's fundamental, if that patch is not present
>     >>    this revert breaks the kernel as per previous discussions[1].
>     >> -  You are sending this patch to all stable kernels that contain the
>     >>    commit you are fixing - some that may not contain the commit above
>     >>    (that was merged in v4.14), you are breaking those kernels, if not
>     >>    explain me why please
> 
>     >If there's a dependency on 0c195567a8f6, I totally agree that
>     >needs to be cleared up.  I was assuming that turned out to be
>     >irrelevant.
> That is right. There is no dependency on 0c195567a8f6. We just need to revert
> 4a9b0933bdfc.

This patch should only be applied to later versions after  0c195567a8f6" (transparent VF). Otherwise it causes long & random names of VF NICs for bonding. That will make bonding config difficult, especially for auto config.

Thanks,
- Haiyang