linux-kernel - [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Apr 2018 13:25:25 -0600
From:   Micah Parrish <micah.parrish@....com>
To:     linux-nvme@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, Kieulien.Dang@...gate.com,
        jeffrey.wang@...gate.com, keith.busch@...el.com,
        pragyansri.pathi@...el.com, micah.parrish@....com
Subject: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage

Add Seagate Nytro Flash Storage nvme drive to quirk list for
NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is
probed on hot-add before the firmare is ready, I/O errors are generated
while reading sector 0, and linux is "unable to read partition table".
This has occurred when the drive is in an NVME drive slot adjacent to an 
Intel drive.

Intel (Keith Busch and Pragyan Pathi) and Seagate (Jeffery Wang
and Kieulien Dang) agreed to add this quirk in off-list discussion.

Signed-off-by: micah.parrish@....com

--- linux/drivers/nvme/host/pci.c.orig	2018-04-05 13:52:23.048890019 -0600
+++ linux/drivers/nvme/host/pci.c	2018-04-09 11:20:57.432900569 -0600
@@ -2687,6 +2687,8 @@ static const struct pci_device_id nvme_i
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS },
 	{ PCI_VDEVICE(INTEL, 0x5845),	/* Qemu emulated controller */
 		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
+	{ PCI_DEVICE(0x1bb1, 0x0100),   /* Seagate Nytro Flash Storage */
+		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
 	{ PCI_DEVICE(0x1c58, 0x0003),	/* HGST adapter */
 		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
 	{ PCI_DEVICE(0x1c58, 0x0023),	/* WDC SN200 adapter */