linux-kernel - Re: [PATCH] media: rc: mtk-cir: use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 11:58:40 +0800
From:   Sean Wang <sean.wang@...iatek.com>
To:     Ryder Lee <ryder.lee@...iatek.com>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] media: rc: mtk-cir: use of_device_get_match_data()

On Mon, 2018-04-16 at 10:34 +0800, Ryder Lee wrote:
> The usage of of_device_get_match_data() reduce the code size a bit.
> 
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> ---
>  drivers/media/rc/mtk-cir.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c
> index e88eb64..e42efd9 100644
> --- a/drivers/media/rc/mtk-cir.c
> +++ b/drivers/media/rc/mtk-cir.c
> @@ -299,8 +299,6 @@ static int mtk_ir_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct device_node *dn = dev->of_node;
> -	const struct of_device_id *of_id =
> -		of_match_device(mtk_ir_match, &pdev->dev);
>  	struct resource *res;
>  	struct mtk_ir *ir;
>  	u32 val;
> @@ -312,7 +310,7 @@ static int mtk_ir_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	ir->dev = dev;
> -	ir->data = of_id->data;
> +	ir->data = of_device_get_match_data(dev);
>  
>  	ir->clk = devm_clk_get(dev, "clk");
>  	if (IS_ERR(ir->clk)) {


Acked-by: Sean Wang <sean.wang@...iatek.com>