linux-kernel - Re: [PATCH] nvme: lightnvm: add granby support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 16:15:38 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Keith Busch <keith.busch@...el.com>,
        Matias Bjørling <mb@...htnvm.io>
Cc:     Wei Xu <wxu@...xlabs.com>, linux-nvme@...ts.infradead.org,
        javier@...xlabs.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: lightnvm: add granby support

On 4/17/18 4:09 PM, Keith Busch wrote:
> On Tue, Apr 17, 2018 at 08:16:25AM +0200, Matias Bjørling wrote:
>> On 4/17/18 3:55 AM, Wei Xu wrote:
>>> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>>>
>>> Signed-off-by: Wei Xu <wxu@...xlabs.com>
>>> ---
>>>   drivers/nvme/host/pci.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>>> index cb73bc8..9419e88 100644
>>> --- a/drivers/nvme/host/pci.c
>>> +++ b/drivers/nvme/host/pci.c
>>> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
>>>   		.driver_data = NVME_QUIRK_LIGHTNVM, },
>>>   	{ PCI_DEVICE(0x1d1d, 0x2807),	/* CNEX WL */
>>>   		.driver_data = NVME_QUIRK_LIGHTNVM, },
>>> +	{ PCI_DEVICE(0x1d1d, 0x2601),	/* CNEX Granby */
>>> +		.driver_data = NVME_QUIRK_LIGHTNVM, },
>>>   	{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
>>>   	{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
>>>   	{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>>>
>>
>> Looks good to me.
>>
>> Reviewed-by: Matias Bjørling <mb@...htnvm.io>
>>
>> Keith, when convenient can you pick this up for 4.18?
> 
> This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> release.

It should wait for the next release, it's not a fix.

-- 
Jens Axboe