linux-kernel - Re: [PATCH 07/11] lightnvm: pblk: remove unnecessary indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 14:11:54 +0200
From:   Matias Bjørling <mb@...htnvm.io>
To:     Javier González <javier@...igon.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Javier González <javier@...xlabs.com>
Subject: Re: [PATCH 07/11] lightnvm: pblk: remove unnecessary indirection

On 4/16/18 12:25 PM, Javier González wrote:
> Remove unnecessary indirection on the read path.
> 

Title and description are the same. Can you elaborate what changed since 
pblk_submit_io now directly can be returned, and doesn't have its return 
value rewritten to NVM_IO_ERR?

> Signed-off-by: Javier González <javier@...xlabs.com>
> ---
>   drivers/lightnvm/pblk-read.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
> index 89aed634333a..2f8224354c62 100644
> --- a/drivers/lightnvm/pblk-read.c
> +++ b/drivers/lightnvm/pblk-read.c
> @@ -102,16 +102,6 @@ static void pblk_read_ppalist_rq(struct pblk *pblk, struct nvm_rq *rqd,
>   #endif
>   }
>   
> -static int pblk_submit_read_io(struct pblk *pblk, struct nvm_rq *rqd)
> -{
> -	int err;
> -
> -	err = pblk_submit_io(pblk, rqd);
> -	if (err)
> -		return NVM_IO_ERR;
> -
> -	return NVM_IO_OK;
> -}
>   
>   static void pblk_read_check_seq(struct pblk *pblk, struct nvm_rq *rqd,
>   				sector_t blba)
> @@ -485,7 +475,7 @@ int pblk_submit_read(struct pblk *pblk, struct bio *bio)
>   		rqd->bio = int_bio;
>   		r_ctx->private = bio;
>   
> -		ret = pblk_submit_read_io(pblk, rqd);
> +		ret = pblk_submit_io(pblk, rqd);
>   		if (ret) {
>   			pr_err("pblk: read IO submission failed\n");
>   			if (int_bio)
>