linux-kernel - Re: [PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Apr 2018 10:08:27 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Jens Axboe <axboe@...nel.dk>, Laurent Vivier <lvivier@...hat.com>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-block@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

Hi Finn,

On Thu, Apr 12, 2018 at 2:50 AM, Finn Thain <fthain@...egraphics.com.au> wrote:
> The resource size is 0x2000 == end - start + 1.
> Therefore end == start + 0x2000 - 1.
>
> Cc: Laurent Vivier <lvivier@...hat.com>
> Cc: stable@...r.kernel.org # v4.14+
> Tested-by: Stan Johnson <userm57@...oo.com>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> Acked-by: Laurent Vivier <lvivier@...hat.com>
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks, applied and queued for v4.18.

> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -1011,7 +1011,7 @@ int __init mac_platform_init(void)
>                 struct resource swim_rsrc = {
>                         .flags = IORESOURCE_MEM,
>                         .start = (resource_size_t)swim_base,
> -                       .end   = (resource_size_t)swim_base + 0x2000,
> +                       .end   = (resource_size_t)swim_base + 0x1FFF,

BTW, probably you want to change swim_base from u8 * to phys_addr_t, one day.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds