linux-kernel - Re: [PATCH 05/21] regulator: arizona-ldo1: Look up a descriptor and pass to the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Apr 2018 16:02:13 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>
Subject: Re: [PATCH 05/21] regulator: arizona-ldo1: Look up a descriptor and
 pass to the core

On Thu, Apr 19, 2018 at 03:43:22PM +0200, Linus Walleij wrote:
> On Tue, Feb 13, 2018 at 12:06 PM, Charles Keepax
> <ckeepax@...nsource.cirrus.com> wrote:
> > On Mon, Feb 12, 2018 at 02:17:01PM +0100, Linus Walleij wrote:
> >> Instead of passing a global GPIO number, pass a descriptor looked
> >> up with the standard devm_gpiod_get_optional() call.
> >>
> >> We have augmented the GPIO core to look up the regulator special
> >> GPIO "wlf,ldoena" in a separate patch.
> >>
> >> Cc: patches@...nsource.cirrus.com
> >> Cc: Richard Fitzgerald <rf@...nsource.cirrus.com>
> >> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> >> ---
> > Also looking at this more you will need to you
> > devm_gpio_get_from_of_node here since the device tree binding is
> > for wlf,ldoena not wlf,ldoena-gpio. So this patch currently
> > breaks the binding.
> 
> Actually not, because I fixed that in  the special quirk patch
> 6a537d48461d
> "gpio: of: Support regulator nonstandard GPIO properties"
> as mentioned in the commit message. (Will clarify.)

Apologies my bad should have spotted that in the commit message.

Thanks,
Charles