linux-kernel - Re: [REVIEW][PATCH 22/22] signal/xtensa: Use force_sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Apr 2018 09:27:35 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Linux-Arch <linux-arch@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Chris Zankel <chris@...kel.net>, linux-xtensa@...ux-xtensa.org
Subject: Re: [REVIEW][PATCH 22/22] signal/xtensa: Use force_sig_fault where appropriate

On Fri, Apr 20, 2018 at 7:38 AM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> Filling in struct siginfo before calling force_sig_info a tedious and
> error prone process, where once in a great while the wrong fields
> are filled out, and siginfo has been inconsistently cleared.
>
> Simplify this process by using the helper force_sig_fault.  Which
> takes as a parameters all of the information it needs, ensures
> all of the fiddly bits of filling in struct siginfo are done properly
> and then calls force_sig_info.
>
> In short about a 5 line reduction in code for every time force_sig_info
> is called, which makes the calling function clearer.
>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: linux-xtensa@...ux-xtensa.org
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---
>  arch/xtensa/kernel/traps.c | 10 +---------
>  arch/xtensa/mm/fault.c     | 19 +++++--------------
>  2 files changed, 6 insertions(+), 23 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max