linux-kernel - Re: [PATCH] dt-bindings: reset: fix invalid SPDX license identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 09:45:10 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Yixun Lan <yixun.lan@...ogic.com>
cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: fix invalid SPDX license
 identifier

On Mon, 23 Apr 2018, Yixun Lan wrote:

> This fix invalid SPDX license indentifier, also move it to
> first top line according to documentation.
> 
> Link: https://lkml.org/lkml/2018/4/22/713

Please do not use lkml.org links. lkml.org is not always usable. Use;

 https://lkml.kernel.org/r/$MESSAGE-ID

instead. So this would be

 https://lkml.kernel.org/r/alpine.DEB.2.21.1804222108120.6136@nanos.tec.linutronix.de

The reason is that kernel.org is very likely there as long as the kernel
exists, but random archives can vanish, change their URL, etc. The above
address is a redirector to the marc archive, but if that vanishes or stops
working the redirector can point to some other working archive.

> Fixes: c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller")
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Yixun Lan <yixun.lan@...ogic.com>
> ---
>  include/dt-bindings/reset/amlogic,meson-axg-reset.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/dt-bindings/reset/amlogic,meson-axg-reset.h b/include/dt-bindings/reset/amlogic,meson-axg-reset.h
> index ad6f55dabd6d..4a8e52f68fb7 100644
> --- a/include/dt-bindings/reset/amlogic,meson-axg-reset.h
> +++ b/include/dt-bindings/reset/amlogic,meson-axg-reset.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>