linux-kernel - Re: [PATCH] Check for an error when the clock is enabled.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 09:55:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stefan Potyra <Stefan.Potyra@...ktrobit.com>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org,
        sil2review@...ts.osadl.org
Subject: Re: [PATCH] Check for an error when the clock is enabled.

On Thu, Apr 19, 2018 at 03:02:28PM +0200, Stefan Potyra wrote:
> Found by Linux Driver Verification project (linuxtesting.org).

Please fix up your subject line to have something "real" in it, along
with the proper prefix.

And put more context here in the changelog, saying why you are doing
this, this "empty line" doesn't mean anything.

> 
> Fixes: 0814e8d5da2b sc16is7xx: enable the clock

Fixes: 0814e8d5da2b ("sc16is7xx: enable the clock")

is the correct format.

> Signed-off-by: Stefan Potyra <Stefan.Potyra@...ktrobit.com>
> ---
>  drivers/tty/serial/sc16is7xx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 65792a3539d0..243c96025053 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1168,7 +1168,10 @@ static int sc16is7xx_probe(struct device *dev,
>  		else
>  			return PTR_ERR(s->clk);
>  	} else {
> -		clk_prepare_enable(s->clk);
> +		ret = clk_prepare_enable(s->clk);
> +		if (ret)
> +			return ret;
> +

Please fix up the above and resend.

thanks,

greg k-h