linux-kernel - Re: [PATCH 3/6] staging: lustre: remove include/linux/libcfs/linux/linux-cpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 15:13:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     James Simmons <jsimmons@...radead.org>
Cc:     NeilBrown <neilb@...e.com>, Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 3/6] staging: lustre: remove
 include/linux/libcfs/linux/linux-cpu.h

On Mon, Apr 16, 2018 at 04:52:55AM +0100, James Simmons wrote:
> 
> > This include file contains definitions used when CONFIG_SMP
> > is in effect.  Other includes contain corresponding definitions
> > for when it isn't.
> > This can be hard to follow, so move the definitions to the one place.
> > 
> > As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard
> > that macro and just use CONFIG_SMP when needed.
> 
> Nak. The lustre SMP is broken and needed to badly be reworked. I have it 
> ready and can push it. I was waiting to see if I had to rebase it once
> the rc1 stuff but since their is a push to get everything out their I will
> push it.

A NAK on some future code that might show up someday is not how we work
at all, sorry.  That has caused other open source projects to die.
First patch submitted "wins".

And these are good patches.  Nothing wrong with them, they clean stuff
up, remove more lines than they added and that's the proper thing to do
here.  So I've applied the first 4, the last two didn't apply due to
changes from you that were accepted.  See, you benifit also from this :)

thanks,

greg k-h