linux-kernel - Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 09:16:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kirill Marinushkin <k.marinushkin@...il.com>
Cc:     Stefan Wahren <stefan.wahren@...e.com>, devel@...verdev.osuosl.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        Ray Jui <rjui@...adcom.com>, linux-kernel@...r.kernel.org,
        Eric Anholt <eric@...olt.net>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] staging: bcm2835-audio: Disconnect and free
 vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 02:35:50AM +0200, Kirill Marinushkin wrote:
> On 04/23/18 15:50, Greg Kroah-Hartman wrote:
> > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote:
> >> In the current implementation, vchi_instance is inited during the first
> >> call of bcm2835_audio_open_connection(), and is never freed. It causes a
> >> memory leak when the module `snd_bcm2835` is removed.
> >>
> >> Here is how this commit fixes it:
> >>
> >> * the VCHI context (including vchi_instance) is created once in the
> >>   platform's devres
> >> * the VCHI context is allocated and connected once during module_init()
> >> * all created bcm2835_chips have a pointer to this VCHI context
> >> * bcm2835_audio_open_connection() can access the VCHI context through the
> >>   associated bcm2835_chip
> >> * the VCHI context is disconnected and freed once during module_exit()
> >>
> >> After this commit is applied, I don't see other issues with the module's
> >> init/exit, so I also remove the associated TODO task.
> >>
> >> Steps to reproduce the memory leak before this commit:
> > <snip>
> >
> > Patch dropped due to kbuild complaints.
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
> 
> Hello Greg,
> 
> Due to which complains of kbuild is the patch dropped?
> I would like to fix the complains, but I don't see any errors or warnings on my
> side.
> Are you sure that the kbuild test robot did it's job correctly? The log says:
> 
> >> it may well be a FALSE warning
> 
> Please show me what is wrong in my patch.

I have no idea as the patch is long gone from my queue now.  If you
think all is fine, please resend it and I will be glad to review it
again.

thanks,

greg k-h