linux-kernel - Re: [PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 12:32:24 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Felix Kuehling <Felix.Kuehling@....com>,
        "Shaoyun.liu" <shaoyun.liu@....com>,
        Jay Cornwall <Jay.Cornwall@....com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

Thanks, but already fixed in latest upstream tree

Oded

On Thu, Apr 5, 2018 at 7:26 AM, Dmitry V. Levin <ldv@...linux.org> wrote:
> Consistently use types provided by <linux/types.h> via <drm/drm.h>
> to fix the following linux/kfd_ioctl.h userspace compilation errors:
>
> /usr/include/linux/kfd_ioctl.h:266:2: error: unknown type name 'uint64_t'
>   uint64_t tba_addr;  /* to KFD */
> /usr/include/linux/kfd_ioctl.h:267:2: error: unknown type name 'uint64_t'
>   uint64_t tma_addr;  /* to KFD */
> /usr/include/linux/kfd_ioctl.h:268:2: error: unknown type name 'uint32_t'
>   uint32_t gpu_id;  /* to KFD */
> /usr/include/linux/kfd_ioctl.h:269:2: error: unknown type name 'uint32_t'
>   uint32_t pad;
>
> Fixes: d7b9bd2248d79 ("drm/amdkfd: Add support for user-mode trap handlers")
> Cc: <stable@...r.kernel.org> # v4.16
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> ---
>  include/uapi/linux/kfd_ioctl.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
> index f4cab5b3ba9a..111d73ba2d96 100644
> --- a/include/uapi/linux/kfd_ioctl.h
> +++ b/include/uapi/linux/kfd_ioctl.h
> @@ -263,10 +263,10 @@ struct kfd_ioctl_get_tile_config_args {
>  };
>
>  struct kfd_ioctl_set_trap_handler_args {
> -       uint64_t tba_addr;              /* to KFD */
> -       uint64_t tma_addr;              /* to KFD */
> -       uint32_t gpu_id;                /* to KFD */
> -       uint32_t pad;
> +       __u64 tba_addr;         /* to KFD */
> +       __u64 tma_addr;         /* to KFD */
> +       __u32 gpu_id;           /* to KFD */
> +       __u32 pad;
>  };
>
>  #define AMDKFD_IOCTL_BASE 'K'
> --
> ldv