linux-kernel - Re: [PATCH] proc: use #pragma once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 12:26:29 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Christoph Hellwig <hch@...radead.org>, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: use #pragma once

On Wed, Apr 25, 2018 at 11:55:31PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 24, 2018 at 06:54:09AM -0700, Christoph Hellwig wrote:
> > On Tue, Apr 24, 2018 at 12:35:34AM +0300, Alexey Dobriyan wrote:
> > > Bring /proc into 21st century.
> > 
> > Please explain what this actually buys us except for being pointlessly
> > different from the rest of the kernel?
> 
> Negative LOC diff, less junk in preprocessor hashtables.

There are about 20k header files, none of them has #pragma once.
Updating that will bring many unnesessry git commits.

I doubt that one more define in preprocessor tables is a problem we
should fix. The LOC argument also does not sound very convincing. The
include protection is at the top of the file, not mixed among other
code. Replacing 2-3 lines with one will be barely noticeable.