linux-kernel - Re: [PATCH] reset: uniphier: fix USB clock line for LD20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Apr 2018 18:42:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] reset: uniphier: fix USB clock line for LD20

Philipp,

2018-04-12 11:16 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> For LD20, the bit 5 of the offset 0x200c turned out to be a USB3
> reset.  The hardware document says it is the GIO reset despite LD20
> has no GIO bus, confusingly.
>
> Also, fix confusing comments for PXs3.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---

Can you take a look at this, please?




>  drivers/reset/reset-uniphier.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index 360e06b..ac18f2f 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -110,7 +110,7 @@ static const struct uniphier_reset_data uniphier_ld20_sys_reset_data[] = {
>         UNIPHIER_RESETX(4, 0x200c, 2),          /* eMMC */
>         UNIPHIER_RESETX(6, 0x200c, 6),          /* Ether */
>         UNIPHIER_RESETX(8, 0x200c, 8),          /* STDMAC (HSC) */
> -       UNIPHIER_RESETX(12, 0x200c, 5),         /* GIO (PCIe, USB3) */
> +       UNIPHIER_RESETX(14, 0x200c, 5),         /* USB30 */
>         UNIPHIER_RESETX(16, 0x200c, 12),        /* USB30-PHY0 */
>         UNIPHIER_RESETX(17, 0x200c, 13),        /* USB30-PHY1 */
>         UNIPHIER_RESETX(18, 0x200c, 14),        /* USB30-PHY2 */
> @@ -127,8 +127,8 @@ static const struct uniphier_reset_data uniphier_pxs3_sys_reset_data[] = {
>         UNIPHIER_RESETX(6, 0x200c, 9),          /* Ether0 */
>         UNIPHIER_RESETX(7, 0x200c, 10),         /* Ether1 */
>         UNIPHIER_RESETX(8, 0x200c, 12),         /* STDMAC */
> -       UNIPHIER_RESETX(12, 0x200c, 4),         /* USB30 link (GIO0) */
> -       UNIPHIER_RESETX(13, 0x200c, 5),         /* USB31 link (GIO1) */
> +       UNIPHIER_RESETX(12, 0x200c, 4),         /* USB30 link */
> +       UNIPHIER_RESETX(13, 0x200c, 5),         /* USB31 link */
>         UNIPHIER_RESETX(16, 0x200c, 16),        /* USB30-PHY0 */
>         UNIPHIER_RESETX(17, 0x200c, 18),        /* USB30-PHY1 */
>         UNIPHIER_RESETX(18, 0x200c, 20),        /* USB30-PHY2 */
> --
> 2.7.4
>



-- 
Best Regards
Masahiro Yamada