lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Apr 2018 21:46:57 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Wei Wang <wvw@...gle.com> Cc: gregkh@...uxfoundation.org, Wei Wang <wei.vince.wang@...il.com>, Ingo Molnar <mingo@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Crt Mori <cmo@...exis.com>, Alexei Starovoitov <ast@...nel.org>, Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com> Subject: Re: [PATCH] do not call trace_printk on non-debug build On Wed, 25 Apr 2018 04:53:33 +0000 Wei Wang <wvw@...gle.com> wrote: > On Tue, Apr 24, 2018 at 12:26 PM Steven Rostedt <rostedt@...dmis.org> wrote: > > A lot of kernel developers use trace_printk() and I want to make it as > > easy to use as possible. I don't want to add a config to enable it, > > because that would be something that could be rather annoying. > > > Let's add it to checkpatch and see if that can draining the swamp of > > abusers. > > > Currently I see f2fs trace is using this when having CONFIG_F2FS_IO_TRACE, > so I am not sure how checkpatch would work. How about we add a BUILD_BUG > surrounded by a config which would let us flag abuse easily on build time? I don't want a config to have to be set for adding this. That would really irritate myself, as I constantly take configs from others for debugging purposes and then slam trace_printk() all over the place. It would be annoying to have to remember to enable a config. And having a config would also change the way the kernel gets built, and for debugging the less variables the better. But you are correct. I see lots of abusers with trace_printk(). I think it's time for me to start removing them. -- Steve
Powered by blists - more mailing lists