linux-kernel - Re: [PATCH 3/5] ib_srpt: depend on INFINIBAND_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Apr 2018 17:35:00 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Greg Thelen <gthelen@...gle.com>
Cc:     Doug Ledford <dledford@...hat.com>,
        Bart Van Assche <Bart.VanAssche@....com>,
        Christoph Hellwig <hch@....de>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tarick Bedeir <tarick@...gle.com>
Subject: Re: [PATCH 3/5] ib_srpt: depend on INFINIBAND_ADDR_TRANS

On Wed, Apr 25, 2018 at 03:33:39PM -0700, Greg Thelen wrote:
> INFINIBAND_SRPT code depends on INFINIBAND_ADDR_TRANS provided symbols.
> So declare the kconfig dependency.  This is necessary to allow for
> enabling INFINIBAND without INFINIBAND_ADDR_TRANS.
> 
> Signed-off-by: Greg Thelen <gthelen@...gle.com>
> Cc: Tarick Bedeir <tarick@...gle.com>
>  drivers/infiniband/ulp/srpt/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/Kconfig b/drivers/infiniband/ulp/srpt/Kconfig
> index 31ee83d528d9..fb8b7182f05e 100644
> +++ b/drivers/infiniband/ulp/srpt/Kconfig
> @@ -1,6 +1,6 @@
>  config INFINIBAND_SRPT
>  	tristate "InfiniBand SCSI RDMA Protocol target support"
> -	depends on INFINIBAND && TARGET_CORE
> +	depends on INFINIBAND && INFINIBAND_ADDR_TRANS && TARGET_CORE

Isn't INFINIBAND && INFINIBAND_ADDR_TRANS a bit redundant? Can't have
INFINIBAND_ADDR_TRANS without INFINIBAND.

Jason