linux-kernel - Re: [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Apr 2018 09:58:39 +0530
From:   Chandan Vn <vn.chandan@...il.com>
To:     CHANDAN VN <chandan.vn@...sung.com>
Cc:     catalin.marinas@....com, will.deacon@....com,
        Takahiro Akashi <takahiro.akashi@...aro.org>,
        james.morse@....com, robin.murphy@....com,
        Laura Abbott <labbott@...hat.com>, steve.capper@....com,
        kristina.martsenko@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, cpgs@...sung.com
Subject: Re: [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock

Please ignore this mail. I missed replying to the thread.
I have resubmitted over the proper thread.

On Mon, 30 Apr 2018, 09:44 CHANDAN VN, <chandan.vn@...sung.com> wrote:
>
> INITRD reserved area entry is not removed from memblock
> even though initrd reserved area is freed. After freeing
> the memory it is released from memblock. The same can be
> checked from /sys/kernel/debug/memblock/reserved.
>
> The patch makes sure that the initrd entry is removed from
> memblock when keepinitrd is not enabled.
>
> The patch only affects accounting and debugging. This does not
> fix any memory leak.
>
> Signed-off-by: CHANDAN VN <chandan.vn@...sung.com>
> ---
>  arch/arm64/mm/init.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 9f3c47a..1b18b47 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -646,8 +646,10 @@ void free_initmem(void)
>
>  void __init free_initrd_mem(unsigned long start, unsigned long end)
>  {
> -       if (!keep_initrd)
> +       if (!keep_initrd) {
>                 free_reserved_area((void *)start, (void *)end, 0, "initrd");
> +               memblock_free(__virt_to_phys(start), end - start);
> +       }
>  }
>
>  static int __init keepinitrd_setup(char *__unused)
> --
> 1.9.1
>