linux-kernel - Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Apr 2018 12:41:24 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Nipun Gupta <nipun.gupta@....com>
Cc:     robin.murphy@....com, hch@....de, linux@...linux.org.uk,
        gregkh@...uxfoundation.org, m.szyprowski@...sung.com,
        bhelgaas@...gle.com, zajec5@...il.com, andy.gross@...aro.org,
        david.brown@...aro.org, dan.j.williams@...el.com,
        vinod.koul@...el.com, robh+dt@...nel.org, frowand.list@...il.com,
        jarkko.sakkinen@...ux.intel.com, rafael.j.wysocki@...el.com,
        dmitry.torokhov@...il.com, johan@...nel.org, msuchanek@...e.de,
        linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
        linux-wireless@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, dmaengine@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
        bharat.bhushan@....com, leoyang.li@....com
Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus
 infrastructure

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote:
[...]
> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
> index 88a3558..a9ec99d 100644
> --- a/drivers/gpu/host1x/bus.c
> +++ b/drivers/gpu/host1x/bus.c
> @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv)
>  	return strcmp(dev_name(dev), drv->name) == 0;
>  }
>  
> +static int host1x_dma_configure(struct device *dev)
> +{
> +	if (dev->of_node)
> +		return of_dma_configure(dev, dev->of_node);

The conditional here is somewhat pointless since the of_node should
always be set. If it weren't it should be considered a bug and this
function welcome to crash to make that very obvious.

Either way:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)