linux-kernel - Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 11:14:48 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     alexander.shishkin@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

Any comment for this patch ?

On Tue, Apr 17, 2018 at 7:45 PM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  drivers/hwtracing/intel_th/msu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
> index dfb57ea..0ac84eb 100644
> --- a/drivers/hwtracing/intel_th/msu.c
> +++ b/drivers/hwtracing/intel_th/msu.c
> @@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
>         mutex_unlock(&msc->buf_mutex);
>  }
>
> -static int msc_mmap_fault(struct vm_fault *vmf)
> +static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
>  {
>         struct msc_iter *iter = vmf->vma->vm_file->private_data;
>         struct msc *msc = iter->msc;
> --
> 1.9.1
>