linux-kernel - Re: [PATCH v8 11/13] arm64: topology: enable ACPI/PPTT based CPU topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 10:24:14 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     Jeremy Linton <jeremy.linton@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
        Hanjun Guo <hanjun.guo@...aro.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Will Deacon <Will.Deacon@....com>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <Mark.Rutland@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-riscv@...ts.infradead.org, wangxiongfeng2@...wei.com,
        vkilari@...eaurora.org, Al Stone <ahs3@...hat.com>,
        Dietmar Eggemann <Dietmar.Eggemann@....com>,
        Morten Rasmussen <Morten.Rasmussen@....com>, palmer@...ive.com,
        Len Brown <lenb@...nel.org>,
        John Garry <john.garry@...wei.com>, austinwc@...eaurora.org,
        tnowicki@...iumnetworks.com, jhugo@....qualcomm.com,
        timur@....qualcomm.com, Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v8 11/13] arm64: topology: enable ACPI/PPTT based CPU topology

On Tue, May 1, 2018 at 4:46 PM, Sudeep Holla <sudeep.holla@....com> wrote:
>
>
> On 26/04/18 00:31, Jeremy Linton wrote:
>> Propagate the topology information from the PPTT tree to the
>> cpu_topology array. We can get the thread id and core_id by assuming
>> certain levels of the PPTT tree correspond to those concepts.
>> The package_id is flagged in the tree and can be found by calling
>> find_acpi_cpu_topology_package() which terminates
>> its search when it finds an ACPI node flagged as the physical
>> package. If the tree doesn't contain enough levels to represent
>> all of the requested levels then the root node will be returned
>> for all subsequent levels.
>>
>
> Acked-by: Sudeep Holla <sudeep.holla@....com>
>
> [..]
>
>> @@ -304,6 +345,8 @@ void __init init_cpu_topology(void)
>>        * Discard anything that was parsed if we hit an error so we
>>        * don't use partial information.
>>        */
>> -     if (of_have_populated_dt() && parse_dt_topology())
>> +     if ((!acpi_disabled) && parse_acpi_topology())
>
> [nit] not sure if extra () is need above,

No, it isn't.

> but I am fine either way.

The redundant parens need to go away, really.