linux-kernel - Re: [PATCH v3 1/4] tpm: Add explicit endianness cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 02 May 2018 08:49:41 +0000
From:   Thiebaud Weksteen <tweek@...gle.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Nayna Jain <nayna@...ux.vnet.ibm.com>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] tpm: Add explicit endianness cast

On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen <
jarkko.sakkinen@...ux.intel.com> wrote:

> On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote:
> > Signed-off-by: Thiebaud Weksteen <tweek@...gle.com>
> > ---
> >  drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm_eventlog_of.c
b/drivers/char/tpm/tpm_eventlog_of.c
> > index 96fd5646f866..ea0f16f19d73 100644
> > --- a/drivers/char/tpm/tpm_eventlog_of.c
> > +++ b/drivers/char/tpm/tpm_eventlog_of.c
> > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
> >        * but physical tpm needs the conversion.
> >        */
> >       if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
> > -             size = be32_to_cpup(sizep);
> > -             base = be64_to_cpup(basep);
> > +             size = be32_to_cpup((__force __be32 *)sizep);
> > +             base = be64_to_cpup((__force __be64 *)basep);
> >       } else {
> >               size = *sizep;
> >               base = *basep;
> > --
> > 2.17.0.484.g0c8726318c-goog
> >

> Repeal and replace, right (no change log)?

Yep, that's right. Thanks.


> /Jarkko