linux-kernel - Re: [PATCH] drm/amd/display: clean up assignment of amdgpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 11:04:29 -0400
From:   Harry Wentland <harry.wentland@....com>
To:     Colin King <colin.king@...onical.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Zhou <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

On 2018-05-02 10:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The declaration of pointer amdgpu_crtc has a redundant assignment to
> amdgpu_crtc. Clean this up by removing it.
> 
> Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks like i goofed. Thanks for fixing this.

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 1dd1142246c2..2beb8821e19e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
>  static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
>  			       struct dc_cursor_position *position)
>  {
> -	struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
> +	struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
>  	int x, y;
>  	int xorigin = 0, yorigin = 0;
>  
>