linux-kernel - Re: [PATCH] proc: restore seekdir("/proc", 256) semantics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 21:10:06 +0200
From:   Pavel Machek <pavel@....cz>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH] proc: restore seekdir("/proc", 256) semantics

Hi!

> Long time ago "/proc/self" was an honest symlink and all not-PID entries
> were output before /proc/$PID. To not lose /proc/self in readdir output
> after it became permanently positive dentry it was stuck before /proc/1.
> 
> One side effect of the change was that the code
> 
> 	d = opendir("/proc");
> 	seekdir(d, 256);
> 
> stopped pointing to the first PID for applications that want to skip all
> the crap.
> 
> Later "/proc/thread-self" was added in the same way.
> 
> It looks like ps and top aren't seeking over /proc but are simply
> skipping over so nobody noticed.
> 
> Restore old behaviour, make seekdir(254) point to /proc/self and
> seekdir(255) point to /proc/thread-self.

Is there anyone relying on the old behaviour?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html