linux-kernel - Re: [PATCH] kbuild/debian: Use KBUILD_BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 21:31:33 +0200
From:   Mathieu Malaterre <malat@...ian.org>
To:     Riku Voipio <riku.voipio@...aro.org>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild/debian: Use KBUILD_BUILD_* when set

On Wed, May 2, 2018 at 9:27 PM, Mathieu Malaterre <malat@...ian.org> wrote:
> On Wed, May 2, 2018 at 1:30 PM, Riku Voipio <riku.voipio@...aro.org> wrote:
>> On 23 April 2018 at 22:50, Mathieu Malaterre <malat@...ian.org> wrote:
>>> Be nice to the user and check env vars KBUILD_BUILD_USER &
>>> KBUILD_BUILD_HOST when those are set.
>>
>> mkdebian sets the maintainer address as "$name <$email>", but this
>> patch only sets the email part. I also wonder about the precedence, I
>> think KBUILD_* should be considered over the generic Debian variables.
>
> I simply tried to re-use the KBUILD_* env vars whenever possible. This
> did made sense, since:
>
> $ dmesg|grep debian
>                                                                   ~
> [    0.000000] Linux version 4.14.0-0.bpo.3-amd64
> (debian-kernel@...ts.debian.org) (gcc version 6.3.0 20170516 (Debian
> 6.3.0-18)) #1 SMP Debian 4.14.13-1~bpo9+1 (2018-01-14)
>
> and
>
> $ apt-cache show linux-image-amd64| grep Main
>                                                                   ~
> Maintainer: Debian Kernel Team <debian-kernel@...ts.debian.org>
>
> I do not believe this should take precedence over DEBEMAIL.

It seems that the env var DEBEMAIL is now accepting a new syntax (at
least I was not aware of this syntax):

https://manpages.debian.org/unstable/devscripts/dch.1.en.html

[...]If the environment variable DEBEMAIL is set, this will be used
for the email address. If this variable has the form "name <email>",
then the maintainer name will also be taken from here[...]

I'll send a v2 that check DEBEMAIL does not contains '<>'.

>> Riku
>>
>>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>>> ---
>>>  scripts/package/mkdebian | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
>>> index 6adb3a16ba3b..05d58d3ae8a0 100755
>>> --- a/scripts/package/mkdebian
>>> +++ b/scripts/package/mkdebian
>>> @@ -76,6 +76,8 @@ if [ -n "$DEBEMAIL" ]; then
>>>         email=$DEBEMAIL
>>>  elif [ -n "$EMAIL" ]; then
>>>         email=$EMAIL
>>> +elif [ -n "$KBUILD_BUILD_USER" ] && [ -n "$KBUILD_BUILD_HOST" ]; then
>>> +       email=$KBUILD_BUILD_USER@...UILD_BUILD_HOST
>>>  else
>>>         email=$(id -nu)@$(hostname -f 2>/dev/null || hostname)
>>>  fi
>>> --
>>> 2.11.0
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
>>> the body of a message to majordomo@...r.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html