linux-kernel - Re: [PATCH 00/11] PM / Domains: Fixup error paths with dev_pm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 May 2018 10:31:06 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Vinod Koul <vinod.koul@...el.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Russell King <linux@...linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 00/11] PM / Domains: Fixup error paths with dev_pm_domain_attach()

On Wed, May 2, 2018 at 2:31 PM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 26 April 2018 at 10:52, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>> While I was on working adding support for multiple PM domains to genpd, I
>> stumbled over several problems in the error path related to
>> dev_pm_domain_attach(). Hence, I decided to fix these problems first, which is
>> what this series intends to address.
>>
>> There first patch is material for stable, as it fixes a real bug in genpd,
>> while the rest may be considered as improvement of the error paths when devices
>> fails to be attached to their PM domains.
>>
>> I am seeking acks from subsystem maintainers and suggest with funnel the hole
>> series through Rafael's linux-pm tree, unless there are objections to that of
>> course.
>>
>> Ulf Hansson (11):
>>   PM / Domains: Fix error path during attach in genpd
>>   PM / Domains: Drop comment in genpd about legacy Samsung DT binding
>>   PM / Domains: Drop redundant code in genpd while attaching devices
>>   PM / Domains: Check for existing PM domain in dev_pm_domain_attach()
>>   PM / Domains: Allow a better error handling of dev_pm_domain_attach()
>>   amba: Respect all error codes from dev_pm_domain_attach()
>>   driver core: Respect all error codes from dev_pm_domain_attach()
>>   i2c: Respect all error codes from dev_pm_domain_attach()
>>   mmc: sdio: Respect all error codes from dev_pm_domain_attach()
>>   soundwire: Respect all error codes from dev_pm_domain_attach()
>>   spi: Respect all error codes from dev_pm_domain_attach()
>>
>>  drivers/acpi/device_pm.c     |  9 +++------
>>  drivers/amba/bus.c           |  4 ++--
>>  drivers/base/platform.c      | 17 ++++++++---------
>>  drivers/base/power/common.c  | 10 +++++++---
>>  drivers/base/power/domain.c  | 45 +++++++++++++++-----------------------------
>>  drivers/i2c/i2c-core-base.c  |  2 +-
>>  drivers/mmc/core/sdio_bus.c  |  2 +-
>>  drivers/soundwire/bus_type.c | 15 +++++++--------
>>  drivers/spi/spi.c            | 11 ++++++-----
>>  include/linux/acpi.h         |  2 +-
>>  include/linux/pm_domain.h    |  2 +-
>>  11 files changed, 52 insertions(+), 67 deletions(-)
>
> Rafael,
>
> I understand if you are busy so this is not a ping. :-)
>
> However, perhaps I can simplify by sending you a PR with these!?

Yes, please.

I'm going to have a look at the patches anyway, but I'm not expecting
to see anything objectionable in them honestly. :-)