linux-kernel - Re: [PATCH v2 0/3] Few NFC fixes from android-4.14 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 03 May 2018 13:21:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Amit Pundir <amit.pundir@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>,
        linux-wireless@...r.kernel.org
Cc:     Suren Baghdasaryan <surenb@...gle.com>,
        Samuel Ortiz <sameo@...ux.intel.com>,
        Christophe Ricard <christophe.ricard@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        John Stultz <john.stultz@...aro.org>,
        Dmitry Shmidt <dimitrysh@...gle.com>,
        Todd Kjos <tkjos@...gle.com>,
        Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH v2 0/3] Few NFC fixes from android-4.14 tree

On Wed, 2018-05-02 at 23:18 +0530, Amit Pundir wrote:
> Hi,
> 
> Submitting v2 of NFC fixes I picked up from android-4.14 tree[1]
> for review and comments.
> 
> Again like to point out that I have not feature tested these patches
> at all. Only made small cosmetic changes to the original patches
> (removed Android-only tag and internal bug ID) and build tested for
> arm, before posting them here for review.
> 
> Really appreciate any comments or feedback on how to take it forward.
> 
> Changes since v1:
> * Dropped "NFC: st21nfca: Fix memory OOB and leak issues in
> connectivity
>   events handler" patch for now. I'm yet to verify if the additional
>   aid_len and params_len checks for buffer size are really required,
> and
>   I didn't want to hold up this patch series for one patch alone.
> * Dropped redundant __func__ use dev_dbg() in "NFC: fdp: Fix possible
>   buffer overflow in WCS4000 NFC driver" patch.
> 
> Also drivers/nfc/fdp/ is full of __func__ parameter usage in
> dev_dbg(),
> so submitting a new patch separately to clean that up.
> 

After addressing one comment, FWIW,

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Regards,
> Amit Pundir
> [1] https://android.googlesource.com/kernel/common/+log/android-4.14
> 
> Suren Baghdasaryan (3):
>   NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ
>   NFC: Fix possible memory corruption when handling SHDLC I-Frame
>     commands
>   NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver
> 
>  drivers/nfc/fdp/fdp.c      | 22 +++++++++++-----------
>  drivers/nfc/fdp/i2c.c      | 29 ++++++++++++++++++-----------
>  drivers/nfc/st21nfca/dep.c |  3 ++-
>  net/nfc/hci/core.c         | 10 ++++++++++
>  4 files changed, 41 insertions(+), 23 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy