linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 May 2018 16:23:13 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     kernel@...gutronix.de, fabio.estevam@....com, robh+dt@...nel.org,
        mark.rutland@....com, Linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support

On Fri, Apr 27, 2018 at 02:58:08PM +0800, Anson Huang wrote:
> There is a debug LED(D11) connected to GPIO1_IO24, add
> support for it.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> this patch is based on patch series (ARM: dts: imx6sx-sabreauto: add wdog external reset support).

In this case, you can include these two patches into the series, if you
need to resend the series.

Shawn

>  arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index eb1452c..6b94f24 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -18,6 +18,18 @@
>  		reg = <0x80000000 0x80000000>;
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_led>;
> +
> +		user {
> +			label = "debug";
> +			gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +
>  	regulators {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
> @@ -119,6 +131,12 @@
>  &iomuxc {
>  	imx6x-sabreauto {
>  
> +		pinctrl_led: ledgrp {
> +			fsl,pins = <
> +				MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> +			>;
> +		};
> +

Try to sort the pinctrl node alphabetically.

Shawn

>  		pinctrl_enet1_1: enet1grp-1 {
>  			fsl,pins = <
>  				MX6SX_PAD_ENET1_MDIO__ENET1_MDIO        0xa0b1
> -- 
> 2.7.4
>